soarez commented on code in PR #15522:
URL: https://github.com/apache/kafka/pull/15522#discussion_r1546351970
##########
core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala:
##########
@@ -105,7 +105,7 @@ class ReplicaAlterLogDirsThread(name: String,
topicId <- partition.topicId
directoryId <- partition.logDirectoryId()
topicIdPartition = new TopicIdPartition(topicId,
topicPartition.partition())
- } directoryEventHandler.handleAssignment(topicIdPartition, directoryId, ()
=> ())
+ } directoryEventHandler.handleAssignment(topicIdPartition, directoryId,
"Reverting queued dir reassignment mid future replica promotion", () => ())
Review Comment:
These aren't the words we'd want to couple together. I meant "mid [future
replica promotion]". i.e. in the middle of the process of promoting a future
replica. Perhaps there's a better way to express this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
