mcmmining commented on PR #14881: URL: https://github.com/apache/kafka/pull/14881#issuecomment-2030156545
> - Extended `LogManager.getOrCreateLog` to accept the target directory's ID. At this level, we assume that the directory id is online to keep `getOrCreateLog` simple. > - Fixed `LogManager.handleLogDirFailure`to remove failed directory from `directoryIds` alongside `_liveLogDirs`. > - Update `Partition.makeLeader` and `Partition.makeFollower` to decide whether or not to send the directory's ID down to `LogManager.getOrCreateLog`. > - `ReplicaManage.applyLocalLeadersDelta` and `ReplicaManager.applyLocalFollowersDelta` will correct the assignment if the `Partition.log` doesn't equal the assigned in received `TopicDelta.partitionChanges` by the replica manager. > > **_Update_** > - Deleted `ReplicaManager.maybeNotifyPartitionAssignedToDirectory` as this one is redundant now. > > > ### Committer Checklist (excluded from commit message) > - [ ] Verify design and implementation > - [ ] Verify test coverage and CI build status > - [ ] Verify documentation (including upgrade notes) > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
