Joker-5 commented on code in PR #15642: URL: https://github.com/apache/kafka/pull/15642#discussion_r1547632847
########## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectorValidationIntegrationTest.java: ########## @@ -343,7 +346,7 @@ public void testConnectorHasConverterWithNoSuitableConstructor() throws Interrup @Test public void testConnectorHasConverterThatThrowsExceptionOnInstantiation() throws InterruptedException { Map<String, String> config = defaultSinkConnectorProps(); - config.put(KEY_CONVERTER_CLASS_CONFIG, TestConverterWithConstructorThatThrowsException.class.getName()); + config.put(KEY_CONVERTER_CLASS_CONFIG, TestPlugins.TestPlugin.ALWAYS_THROW_EXCEPTION.className()); Review Comment: At the beginning I used `BAD_PACKAGING_DEFAULT_CONSTRUCTOR_THROWS_CONNECTOR` in the case, but I thought `ALWAYS_THROW_EXCEPTION` has stronger sematics, that's why I changed my mind. But now I think about the case again, I think `BAD_PACKAGING_DEFAULT_CONSTRUCTOR_THROWS_CONNECTOR ` has fine-grain sematics which is more suitable for the case. So I will change it. Thanks so much for pointing out that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org