chia7712 commented on code in PR #15621:
URL: https://github.com/apache/kafka/pull/15621#discussion_r1550271336
##########
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##########
@@ -56,11 +60,38 @@ class ListOffsetsIntegrationTest extends
KafkaServerTestHarness {
@AfterEach
override def tearDown(): Unit = {
- setOldMessageFormat = false
+ version = RecordBatch.MAGIC_VALUE_V2
Utils.closeQuietly(adminClient, "ListOffsetsAdminClient")
super.tearDown()
}
+ @ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
+ @ValueSource(strings = Array("zk", "kraft"))
+ def testListMaxTimestampWithEmptyLog(quorum: String): Unit = {
+ val maxTimestampOffset = runFetchOffsets(adminClient,
OffsetSpec.maxTimestamp(), topicName)
+ assertEquals(ListOffsetsResponse.UNKNOWN_OFFSET,
maxTimestampOffset.offset())
+ assertEquals(ListOffsetsResponse.UNKNOWN_TIMESTAMP,
maxTimestampOffset.timestamp())
+ }
+
+ @ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
+ @ValueSource(strings = Array("zk"))
+ def testListVersion0(quorum: String): Unit = {
Review Comment:
@junrao this is the new test case for the version 0 that we should get `-1`
if the magic value is 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
