lianetm commented on code in PR #15585:
URL: https://github.com/apache/kafka/pull/15585#discussion_r1555915666
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1667,6 +1669,7 @@ private void updateLastSeenEpochIfNewer(TopicPartition
topicPartition, OffsetAnd
public boolean updateAssignmentMetadataIfNeeded(Timer timer) {
maybeThrowFencedInstanceException();
maybeInvokeCommitCallbacks();
+ maybeUpdateSubscriptionMetadata();
backgroundEventProcessor.process();
// Keeping this updateAssignmentMetadataIfNeeded wrapping up the
updateFetchPositions as
Review Comment:
Since we're here, and adding logic that adds to the purpose of this
`updateAssignmentMetadataIfNeeded`, we could clean up and remove this outdated
comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
