jolshan commented on code in PR #15657:
URL: https://github.com/apache/kafka/pull/15657#discussion_r1556584820
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -979,6 +1013,13 @@ void handleCoordinatorReady() {
null;
this.coordinatorSupportsBumpingEpoch = initProducerIdVersion != null &&
initProducerIdVersion.maxVersion() >= 3;
+
+ // TODO(caliu) use feature version.
+ ApiVersion produceVersion = nodeApiVersions != null ?
+ nodeApiVersions.apiVersion(ApiKeys.PRODUCE) :
+ null;
+ this.coordinatorSupportsTransactionV2 = produceVersion != null &&
Review Comment:
I think the other thing we are looking for is in the txn offset commit
request and the produce request, setting the version to 11 and 4 until
v2/feature version is enabled. I didn't see that here yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
