nizhikov commented on PR #15645: URL: https://github.com/apache/kafka/pull/15645#issuecomment-2044356548
> Does ConfigCommandIntegrationTest have only zk-related tests? Yes. > If so, we don't need to rewrite it by java as it will be removed directly. Are you suggest to rewrite command and all tests to java but keep one test in scala? Let's rewrite all code to java. Seems, like PR ready to review and merge :) > For another, it seems that we don't have integration test for broker configs? Can you, please, clarify - are you suggest to extend `ConfigCommandIntegrationTest` to test cases with broker configs? If we decide to rewrite this test in java, can we extend it after merge? Or you want to create more test cases for scala version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org