FrankYang0529 opened a new pull request, #15687: URL: https://github.com/apache/kafka/pull/15687
Sometimes we want to define server properties for all test cases, and using `BeforeEach` to modify the `ClusterConfig` is the only way. The side effect is that the IDE does not like the style since IDE can't recognize custom ParameterResolver of `ClusterConfig`. The alternative is that we can take `ClusterInstance` from constructor first, and then we modify the inner `ClusterConfig` in `BeforeEach` phase. However, that may confuse users about the life cycle of "configs". In short, I prefer to define the server property by `ClusterTestDefaults`. It already includes some server-side default property, and we can enhance that to deal with more existent test case. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
