cadonna commented on code in PR #15669:
URL: https://github.com/apache/kafka/pull/15669#discussion_r1557815764


##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##########
@@ -498,6 +538,40 @@ public void 
testAutoCommitEmptyDoesNotLeaveInflightRequestFlagOn() {
         verify(commitRequestManger, times(2)).resetAutoCommitTimer();
     }
 
+    @Test
+    public void testAutoCommitOnIntervalSkippedIfPreviousOneInFlight() {
+        TopicPartition t1p = new TopicPartition("topic1", 0);
+        subscriptionState.assignFromUser(singleton(t1p));
+        subscriptionState.seek(t1p, 100);
+
+        CommitRequestManager commitRequestManger = create(true, 100);

Review Comment:
   nit:
   ```suggestion
           CommitRequestManager commitRequestManager = create(true, 100);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to