chia7712 commented on code in PR #15676: URL: https://github.com/apache/kafka/pull/15676#discussion_r1559385018
########## core/src/test/scala/integration/kafka/coordinator/transaction/ProducerIdsIntegrationTest.scala: ########## @@ -19,32 +19,31 @@ package kafka.coordinator.transaction import kafka.network.SocketServer import kafka.server.{IntegrationTestUtils, KafkaConfig} -import kafka.test.annotation.{AutoStart, ClusterTest, ClusterTests, Type} +import kafka.test.ClusterInstance +import kafka.test.annotation.{AutoStart, ClusterConfigProperty, ClusterTest, ClusterTestDefaults, ClusterTests, Type} import kafka.test.junit.ClusterTestExtensions -import kafka.test.{ClusterConfig, ClusterInstance} import org.apache.kafka.common.message.InitProducerIdRequestData import org.apache.kafka.common.network.ListenerName import org.apache.kafka.common.protocol.Errors import org.apache.kafka.common.record.RecordBatch import org.apache.kafka.common.requests.{InitProducerIdRequest, InitProducerIdResponse} import org.apache.kafka.server.common.MetadataVersion import org.junit.jupiter.api.Assertions.{assertEquals, assertTrue} -import org.junit.jupiter.api.{BeforeEach, Disabled, Timeout} import org.junit.jupiter.api.extension.ExtendWith +import org.junit.jupiter.api.{Disabled, Timeout} import java.util.stream.{Collectors, IntStream} import scala.concurrent.duration.DurationInt import scala.jdk.CollectionConverters._ + +@ClusterTestDefaults(serverProperties = Array( + new ClusterConfigProperty(key = "transaction.state.log.num.partitions", value = "1"), + new ClusterConfigProperty(key = "transaction.state.log.replication.factor", value = "3") Review Comment: this is equal to the default value (https://github.com/apache/kafka/blob/trunk/transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionLogConfig.java#L23) , so maybe we can remove it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org