OmniaGM commented on code in PR #15670:
URL: https://github.com/apache/kafka/pull/15670#discussion_r1560820501
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManagerConfig.java:
##########
@@ -17,13 +17,12 @@
package org.apache.kafka.storage.internals.log;
import org.apache.kafka.common.utils.Utils;
+import org.apache.kafka.coordinator.transaction.TransactionLogConfigs;
import java.util.Set;
public class ProducerStateManagerConfig {
- public static final String PRODUCER_ID_EXPIRATION_MS =
"producer.id.expiration.ms";
- public static final String TRANSACTION_VERIFICATION_ENABLED =
"transaction.partition.verification.enable";
- public static final Set<String> RECONFIGURABLE_CONFIGS =
Utils.mkSet(PRODUCER_ID_EXPIRATION_MS, TRANSACTION_VERIFICATION_ENABLED);
+ public static final Set<String> RECONFIGURABLE_CONFIGS =
Utils.mkSet(TransactionLogConfigs.PRODUCER_ID_EXPIRATION_MS_CONFIG,
TransactionLogConfigs.TRANSACTION_PARTITION_VERIFICATION_ENABLE_CONFIG);
Review Comment:
I think this is to follow the same pattern we had `DynamicBrokerConfig
.AllDynamicConfigs` that it refer to list of `RECONFIGURABLE_CONFIGS` from each
module But I also can see that we kinda broke this pattern in
`DynamicBrokerConfig.DynamicSecurityConfigs`,
`DynamicBrokerConfig.DynamicPasswordConfigs` and
`DynamicBrokerConfig.ReloadableFileConfigs`. I'll move to DynamicBrokerConfig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
