OmniaGM commented on PR #15569: URL: https://github.com/apache/kafka/pull/15569#issuecomment-2049673128
The last commit renamed the class to `KafkaLogConfigs` instead similar to `KafkaSecurityConfigs` and `ZKConfigs`. I tried to move some to `LogConfig.ServerLogConfig` similar to `LogConfig.RemoteLogConfig` specially that some default configs are defined in `LogConfig`. However I'm bit concern that `LogConfig` seems already huge. What others prefer? Keep it in `KafkaLogConfigs` or move them to LogConfig.ServerLogConfig` cc: @mimaison, @chia7712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
