showuon commented on PR #15678: URL: https://github.com/apache/kafka/pull/15678#issuecomment-2054458671
@chiacyu , thanks for the update. LGTM! Comments: 1. Please resolve merge conflict 2. In L163, we did: ``` if (readyToAssert.getCount() > 0) { readyToAssert.countDown(); } ``` Actually we can remove the if condition because the javadoc of CountDownLatch#countDown said: > If the current count equals zero then nothing happens. Same comment applies to other similar places. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org