dajac commented on code in PR #15717: URL: https://github.com/apache/kafka/pull/15717#discussion_r1567240139
########## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/AssignPartitionsMicroBenchmark.java: ########## @@ -0,0 +1,153 @@ +package org.apache.kafka.jmh.group_coordinator; Review Comment: I see where you're coming from. I think that the builder could be considered as part of the assignor benchmarks. How about moving the client one to the existing `consumer` package and keeping the remaining ones in a `coordinator` package? We usually don't use package names with `_` so we should change it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
