lianetm commented on PR #15723: URL: https://github.com/apache/kafka/pull/15723#issuecomment-2059130202
Thanks for the changes @kirktrue , LGTM. Just thinking out loud to share a concern and reasoning about it. The flag based approach always makes me think if we would break managers out there that could be using the `canSend` (returns false based on the flag), but not using the other funcs that flip the flag when a response is received/not-received/succeeds/fails. My reasoning then was that given than the previous approach was based in numeric variables that were being set on the same places where the flag is flipped now I would say we can expect that no managers will be affected, so we should be good with it I expect. Thanks for the changes! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
