mimaison commented on code in PR #15469:
URL: https://github.com/apache/kafka/pull/15469#discussion_r1568541184
##########
connect/api/src/main/java/org/apache/kafka/connect/data/Values.java:
##########
@@ -766,135 +852,23 @@ protected static boolean
canParseSingleTokenLiteral(Parser parser, boolean embed
protected static SchemaAndValue parse(Parser parser, boolean embedded)
throws NoSuchElementException {
Review Comment:
I wonder if it would make sense to move all these `parse<>()` methods to the
`Parser` class, and extract `Parser` to its own file. WDYT?
I made a quick attempt in
https://github.com/apache/kafka/commit/10f4910bfc5e0d47782d7a70f8ad22dee97efe12#diff-024f49f1f6adf07bcc1cab6aa8caa0d931ba2c6be887d96ab575ae032be4d051
##########
connect/api/src/main/java/org/apache/kafka/connect/data/Values.java:
##########
@@ -177,7 +213,12 @@ public static Long convertToLong(Schema schema, Object
value) throws DataExcepti
* @throws DataException if the value could not be converted to a float
*/
public static Float convertToFloat(Schema schema, Object value) throws
DataException {
Review Comment:
A few of these `convertTo<>()` methods are not covered by unit tests. It's
ok not to address this in this PR if you'd prefer as it's already huge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
