mdedetrich commented on PR #15341: URL: https://github.com/apache/kafka/pull/15341#issuecomment-2063692520
@OmniaGM So the structure of the PR/tests is now finalized, I ended up entirely deleting `KafkaEmbedded` and so now the tests are a lot closer to idioomatic testing with KRaft/`KafkaClusterTestKit`. Regarding using a global `EmbeddedKafkaCluster`, I think this makes sense to do in a separate PR or at least when I manage to get the tests to pass in this PR. On that note, the current issue with the PR is that not all of the tests are passing, i.e. `HandlingSourceTopicDeletionIntegrationTest` as an example on the top of my head. Currently debugging to figure out why but any help would be appreciated, its likely some config/prop is not properly set -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
