OmniaGM commented on code in PR #15772: URL: https://github.com/apache/kafka/pull/15772#discussion_r1573851135
########## server/src/main/java/org/apache/kafka/server/config/Defaults.java: ########## @@ -46,6 +42,10 @@ public class Defaults { public static final int METADATA_MAX_IDLE_INTERVAL_MS = 500; public static final int METADATA_MAX_RETENTION_BYTES = 100 * 1024 * 1024; public static final boolean DELETE_TOPIC_ENABLE = true; + public static final int REQUEST_TIMEOUT_MS = 30000; + public static final long CONNECTION_SETUP_TIMEOUT_MS = CommonClientConfigs.DEFAULT_SOCKET_CONNECTION_SETUP_TIMEOUT_MS; Review Comment: These will move soon in the final PR couple of prs for moving KafkaConfig out of core. There will be some refactoring to move more stuff into `CommonClientConfigs` and some to `ServerCommonConfigs`. So I would keep it for now until I fully finish this jira. `KafkaConfig.scala` will join the rest of the configs in `server` pretty soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org