kamalcph commented on code in PR #15748:
URL: https://github.com/apache/kafka/pull/15748#discussion_r1576175394
##########
core/src/test/scala/unit/kafka/log/LogCleanerParameterizedIntegrationTest.scala:
##########
@@ -121,9 +121,9 @@ class LogCleanerParameterizedIntegrationTest extends
AbstractLogCleanerIntegrati
// Set the last modified time to an old value to force deletion of old
segments
val endOffset = log.logEndOffset
log.logSegments.foreach(_.lastModified = time.milliseconds - (2 *
retentionMs))
- TestUtils.waitUntilTrue(() => log.logStartOffset == endOffset,
+ TestUtils.waitUntilTrue(() => 1 == log.numberOfSegments,
"Timed out waiting for deletion of old segments")
- assertEquals(1, log.numberOfSegments)
+ assertEquals(log.logStartOffset, endOffset)
Review Comment:
The test is flaky post landing the PR in trunk:
https://ge.apache.org/scans/tests?search.relativeStartTime=P28D&search.rootProjectNames=kafka&search.timeZoneId=Europe%2FBerlin&tests.container=kafka.log.LogCleanerParameterizedIntegrationTest
We have to raise a similar fix in trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
