dajac commented on code in PR #15721:
URL: https://github.com/apache/kafka/pull/15721#discussion_r1577407602
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/Assertions.java:
##########
@@ -198,6 +207,43 @@ private static void assertApiMessageAndVersionEquals(
}
}
}
+ } else if (actual.message() instanceof GroupMetadataValue) {
+ GroupMetadataValue expectedValue = (GroupMetadataValue)
expected.message().duplicate();
+ GroupMetadataValue actualValue = (GroupMetadataValue)
actual.message().duplicate();
+
+
expectedValue.members().sort(Comparator.comparing(GroupMetadataValue.MemberMetadata::memberId));
+
actualValue.members().sort(Comparator.comparing(GroupMetadataValue.MemberMetadata::memberId));
+ try {
+ Arrays.asList(expectedValue, actualValue).forEach(value ->
+ value.members().forEach(memberMetadata -> {
+ // Sort topics and ownedPartitions in Subscription.
+ ConsumerPartitionAssignor.Subscription subscription =
+
ConsumerProtocol.deserializeSubscription(ByteBuffer.wrap(memberMetadata.subscription()));
+ subscription.topics().sort(String::compareTo);
+ subscription.ownedPartitions().sort(
+
Comparator.comparing(TopicPartition::topic).thenComparing(TopicPartition::partition)
+ );
+
memberMetadata.setSubscription(Utils.toArray(ConsumerProtocol.serializeSubscription(
+ subscription,
+
ConsumerProtocol.deserializeVersion(ByteBuffer.wrap(memberMetadata.subscription()))
+ )));
+
+ // Sort partitions in Assignment.
+ ConsumerPartitionAssignor.Assignment assignment =
+
ConsumerProtocol.deserializeAssignment(ByteBuffer.wrap(memberMetadata.assignment()));
+ assignment.partitions().sort(
+
Comparator.comparing(TopicPartition::topic).thenComparing(TopicPartition::partition)
+ );
+
memberMetadata.setAssignment(Utils.toArray(ConsumerProtocol.serializeAssignment(
+ assignment,
+
ConsumerProtocol.deserializeVersion(ByteBuffer.wrap(memberMetadata.assignment()))
+ )));
+ })
+ );
+ } catch (SchemaException ex) {
+ System.out.println("Failed deserialization: " +
ex.getMessage());
Review Comment:
nit: Sorry, I missed this one. We usually don't keep `println` in tests. It
may be better to call `fail` with an appropriate message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
