jolshan commented on code in PR #15657:
URL: https://github.com/apache/kafka/pull/15657#discussion_r1578346148
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -979,6 +1013,13 @@ void handleCoordinatorReady() {
null;
this.coordinatorSupportsBumpingEpoch = initProducerIdVersion != null &&
initProducerIdVersion.maxVersion() >= 3;
+
+ // TODO(caliu) use feature version.
+ ApiVersion produceVersion = nodeApiVersions != null ?
+ nodeApiVersions.apiVersion(ApiKeys.PRODUCE) :
+ null;
+ this.coordinatorSupportsTransactionV2 = produceVersion != null &&
Review Comment:
Sorry I think I used some unclear wording. When I said "checking TV", I
meant using the nodeApiVersions to check the TV on requests -- this will be in
ApiVersionsResponseData.finalizedFeatures. We will also want to check
ApiVersionsResponseData.finalizedFeaturesEpoch when we update the feature
version. I was thinking the transaction manager could have some sort of central
mechanism that checks the api version and updates on the various requests. This
could be done in a helper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
