appchemist commented on code in PR #15647: URL: https://github.com/apache/kafka/pull/15647#discussion_r1580504115
########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ########## @@ -200,6 +200,9 @@ protected void handleFetchSuccess(final Node fetchTarget, if (partitionData.currentLeader().leaderId() != -1 && partitionData.currentLeader().leaderEpoch() != -1) { partitionsWithUpdatedLeaderInfo.put(partition, new Metadata.LeaderIdAndEpoch( Optional.of(partitionData.currentLeader().leaderId()), Optional.of(partitionData.currentLeader().leaderEpoch()))); + } else { + requestMetadataUpdate(metadata, subscriptions, partition); + subscriptions.awaitUpdate(partition); Review Comment: As another alternative, it could change the status to AWAIT_UPDATE in FetchCollector.handleInitializeErrors() only when it's not a KIP-951 case. Upon further thought, it seems possible to differentiate based on the following conditions. ``` completedFetch.partitionData.currentLeader().leaderId() != -1 && completedFetch.partitionData.currentLeader().leaderEpoch() != -1 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org