dongnuo123 commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583125181
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorResult.java:
##########
@@ -80,10 +86,28 @@ public CoordinatorResult(
List<U> records,
T response,
CompletableFuture<Void> appendFuture
+ ) {
+ this(records, response, appendFuture, appendFuture == null);
+ }
+
+ /**
+ * Constructs a Result with records, a response, an append-future, and
replayRecords.
+ *
+ * @param records
+ * @param response
+ * @param appendFuture
+ * @param replayRecords
+ */
+ public CoordinatorResult(
+ List<U> records,
+ T response,
+ CompletableFuture<Void> appendFuture,
+ boolean replayRecords
) {
this.records = Objects.requireNonNull(records);
this.response = response;
this.appendFuture = appendFuture;
+ this.replayRecords = Objects.requireNonNull(replayRecords);
Review Comment:
It's because `replayRecord` is a `Boolean` instead of `boolean`. And this is
because we need to use `replayRecord.hashCode()` to compute the hash for the
CoordinatorResult.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
