rreddy-22 commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1583305142
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1350,6 +1351,11 @@ private
CoordinatorResult<ConsumerGroupHeartbeatResponseData, Record> consumerGr
.withMembers(group.members())
.withStaticMembers(group.staticMembers())
.withSubscriptionMetadata(subscriptionMetadata)
+ .withSubscriptionType(ConsumerGroup.subscriptionType(
+ subscribedTopicsMemberCount,
+ group.numMembers(),
+ group.subscriptionType()
+ ))
Review Comment:
I figured we don't need to compute it if it's not necessary since we aren't
updating the actual value anyways. It is only required in this if block right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
