[ 
https://issues.apache.org/jira/browse/KAFKA-16027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842727#comment-17842727
 ] 

Alexander Aghili commented on KAFKA-16027:
------------------------------------------

Hi [~johnnyhsu], I have added it the feature but messed up with some git 
things. See: https://github.com/apache/kafka/pull/15055
My fork on my Kafka-16027 branch has the new implementation so I don't think 
this is necessary to work on but if you want to help sort out the issues 
related to making a pull request please feel free.

> Refactor MetadataTest#testUpdatePartitionLeadership
> ---------------------------------------------------
>
>                 Key: KAFKA-16027
>                 URL: https://issues.apache.org/jira/browse/KAFKA-16027
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Philip Nee
>            Assignee: Alexander Aghili
>            Priority: Minor
>              Labels: newbie
>
> MetadataTest#testUpdatePartitionLeadership is extremely long.  I think it is 
> pretty close to the 160 line method limit - I tried to modfity it but it 
> would hit the limit when i tried to break things into separated lines.
> The test also contains two tests, so it is best to split it into two separate 
> tests.
> We should also move this to ConsumerMetadata.java



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to