jsancio commented on code in PR #15671:
URL: https://github.com/apache/kafka/pull/15671#discussion_r1586867970
##########
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##########
@@ -370,8 +363,52 @@ private void maybeFireLeaderChange() {
}
}
- @Override
- public void initialize() {
+ public void initialize(
+ Map<Integer, InetSocketAddress> voterAddresses,
+ String listenerName,
+ QuorumStateStore quorumStateStore,
+ Metrics metrics
Review Comment:
Yeah. I am also not happy with this move. We only do this delay
initialization because of integration tests (`QuorumTestHarness`,
`KRaftClusterTestKit`). This is not needed by `**/src/main`.
Once we have KIP-853 fully implemented, I should be able to fix the
integration tests to not use the static voter set and the delayed
initialization.
I create [Remove delayed initialization because of static voter
set](https://issues.apache.org/jira/browse/KAFKA-16653) to track this work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
