[
https://issues.apache.org/jira/browse/KAFKA-16654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842808#comment-17842808
]
TaiJuWu commented on KAFKA-16654:
---------------------------------
Hi [~chia7712] ,
If you are not working on it, could you assign it to me?
> Refactor kafka.test.annotation.Type and ClusterTestExtensions
> -------------------------------------------------------------
>
> Key: KAFKA-16654
> URL: https://issues.apache.org/jira/browse/KAFKA-16654
> Project: Kafka
> Issue Type: Improvement
> Reporter: Chia-Ping Tsai
> Assignee: Chia-Ping Tsai
> Priority: Minor
>
> It seems to me the refactor could include following tasks.
> 1. change `invocationContexts`, method invoked by `ClusterTemplate`, and
> generate-related methods in `ClusterTestExtensions` to return a
> java.util.Collection instead of accepting a `java.util.function.Consumer`.
> That can brings two benefit. 1) more simple in production: we don't need to
> create a List and then pass it to be a function to collect stuff. 2) more
> easy to write unit test.
> 2. separate `provideTestTemplateInvocationContexts` to multi methods to
> handle each annotation. That can help us to write tests, and make core more
> readable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
