dajac opened a new pull request, #15847:
URL: https://github.com/apache/kafka/pull/15847

   While reviewing https://github.com/apache/kafka/pull/15785, I noticed that 
the member is added to the group directly in 
`ConsumerGroup#getOrMaybeCreateMember`. This does not hurt but confuses people 
because the state must not be mutated at this point. It should only be mutated 
when records are replayed. I think that it is better to remove it in order to 
make it clear.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to