johnnychhsu commented on code in PR #15845:
URL: https://github.com/apache/kafka/pull/15845#discussion_r1587770348
##########
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##########
@@ -612,7 +613,12 @@ class ZkMigrationIntegrationTest {
val readyFuture =
kraftCluster.controllers().values().asScala.head.controller.waitForReadyBrokers(3)
// Allocate a block of producer IDs while in ZK mode
- val nextProducerId =
sendAllocateProducerIds(zkCluster.asInstanceOf[ZkClusterInstance]).get(30,
TimeUnit.SECONDS)
+ var nextProducerId = -1L
+
+ TestUtils.retry(60000) {
+ assertDoesNotThrow((() => nextProducerId =
sendAllocateProducerIds(zkCluster.asInstanceOf[ZkClusterInstance]).get(20,
TimeUnit.SECONDS)): Executable)
+ }
+ assertEquals(0, nextProducerId)
Review Comment:
may I know why do we need this `assertEquals(0, nextProducerId)` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
