lucasbru commented on code in PR #15784:
URL: https://github.com/apache/kafka/pull/15784#discussion_r1588371452
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/WakeupTrigger.java:
##########
@@ -43,8 +43,12 @@ public void wakeup() {
return new WakeupFuture();
} else if (task instanceof ActiveFuture) {
ActiveFuture active = (ActiveFuture) task;
- active.future().completeExceptionally(new WakeupException());
- return null;
+ boolean wasTriggered =
active.future().completeExceptionally(new WakeupException());
Review Comment:
Could we add a test in `WakeupTriggerTest` for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
