jeffkbkim commented on code in PR #15835:
URL: https://github.com/apache/kafka/pull/15835#discussion_r1589342058
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorRuntimeMetrics.java:
##########
@@ -208,8 +209,8 @@ public void recordEventQueueTime(long durationMs) { }
public void recordEventQueueProcessingTime(long durationMs) { }
@Override
- public void recordThreadIdleRatio(double ratio) {
- threadIdleRatioSensor.record(ratio);
+ public synchronized void recordThreadIdleTime(long idleTimeMs, long
currentTimeMs) {
+ threadIdleTimeRate.record(metrics.config(), idleTimeMs, currentTimeMs);
Review Comment:
A sensor requires both "total" and "rate" metrics. Since the "total idle
time" metric is more or less useless, I have removed it. But this requires us
to directly instantiate the Rate object.
The alternative would be to revert it to a Sensor and also create a "total"
metric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
