cadonna commented on code in PR #15870:
URL: https://github.com/apache/kafka/pull/15870#discussion_r1591223152


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -602,6 +608,47 @@ private void removeUnusedTaskFromStateUpdater(final TaskId 
taskId) {
         tasks.addPendingTaskToCloseClean(taskId);
     }
 
+    private void addToTasksToClose(final Map<TaskId, 
CompletableFuture<StateUpdater.RemovedTaskResult>> futures,
+                                   final Set<Task> 
tasksToCloseCleanFromStateUpdater,
+                                   final Set<Task> 
tasksToCloseDirtyFromStateUpdater) {
+        iterateAndActOnFuture(futures, removedTaskResult -> {
+            final Task task = removedTaskResult.task();
+            final Optional<RuntimeException> exception = 
removedTaskResult.exception();
+            if (exception.isPresent()) {
+                tasksToCloseDirtyFromStateUpdater.add(task);

Review Comment:
   Ah, OK, yes they are logged in the `DefaultStateUpdater` when they happen.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to