lianetm commented on code in PR #15877:
URL: https://github.com/apache/kafka/pull/15877#discussion_r1593116655
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##########
@@ -106,10 +103,9 @@ public void setup() {
commitRequestManager =
testBuilder.commitRequestManager.orElseThrow(IllegalStateException::new);
offsetsRequestManager = testBuilder.offsetsRequestManager;
coordinatorRequestManager =
testBuilder.coordinatorRequestManager.orElseThrow(IllegalStateException::new);
- heartbeatRequestManager =
testBuilder.heartbeatRequestManager.orElseThrow(IllegalStateException::new);
- memberhipsManager =
testBuilder.membershipManager.orElseThrow(IllegalStateException::new);
+ HeartbeatRequestManager heartbeatRequestManager =
testBuilder.heartbeatRequestManager.orElseThrow(IllegalStateException::new);
Review Comment:
btw, removing all those unused might help us remove the suppression
ClassDataAbstractionCoupling, worth checking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
