jolshan commented on code in PR #15837:
URL: https://github.com/apache/kafka/pull/15837#discussion_r1594302111
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -3036,15 +3061,32 @@ class KafkaApisTest extends Logging {
assertEquals(expectedErrors, markersResponse.errorsByProducerId.get(1L))
}
- @Test
- def shouldAppendToLogOnWriteTxnMarkersWhenCorrectMagicVersion(): Unit = {
+ @ParameterizedTest
+ @ValueSource(strings = Array("ALTER", "CLUSTER_ACTION"))
+ def
shouldAppendToLogOnWriteTxnMarkersWhenCorrectMagicVersion(allowedAclOperation:
String): Unit = {
val topicPartition = new TopicPartition("t", 0)
val request = createWriteTxnMarkersRequest(asList(topicPartition))._2
when(replicaManager.getMagic(topicPartition))
.thenReturn(Some(RecordBatch.MAGIC_VALUE_V2))
val requestLocal = RequestLocal.withThreadConfinedCaching
- kafkaApis = createKafkaApis()
+
+ // Allowing WriteTxnMarkers API with the help of AlterCluster ACL.
Review Comment:
nit: should we include both acls?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
