C0urante commented on code in PR #15906:
URL: https://github.com/apache/kafka/pull/15906#discussion_r1595528749
##########
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/DedicatedMirrorIntegrationTest.java:
##########
@@ -353,6 +353,9 @@ private <T extends SourceConnector> void
awaitTaskConfigurations(MirrorMaker mm,
.map(TaskInfo::config)
.allMatch(predicate);
} catch (Exception ex) {
+ if (ex instanceof RebalanceNeededException) {
+ throw ex;
+ }
Review Comment:
Can we add a comment here explaining this non-obvious behavior?
```suggestion
if (ex instanceof RebalanceNeededException) {
// It's okay to retry on this error; happens when a
worker has read a new config
// from the config topic but hasn't completed the
subsequent rebalance yet
throw ex;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
