jeffkbkim commented on code in PR #15902:
URL: https://github.com/apache/kafka/pull/15902#discussion_r1595531424
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##########
@@ -1083,6 +1094,11 @@ public void run() {
public void complete(Throwable exception) {
if (exception == null) {
future.complete(null);
+
+ if (writeTimeoutTask != null) {
Review Comment:
i originally had it only when it completes successfully because
TimerTask#cancel requires synchronization on SystemTimer. I guess we will need
to get a lock on it anyways when it expires anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
