jsancio commented on code in PR #15859:
URL: https://github.com/apache/kafka/pull/15859#discussion_r1595620870
##########
raft/src/main/java/org/apache/kafka/raft/QuorumState.java:
##########
@@ -481,7 +517,7 @@ private void durableTransitionTo(EpochState state) {
}
}
- this.store.writeElectionState(state.election());
+ this.store.writeElectionState(state.election(),
latestKraftVersion.get());
Review Comment:
Yeah. I am also not a fan of this inconsistency. I try to change them as I
modifying related lines. I'll go through this file and fix all of the ones I
can find.
I think the convention is to not use `this` unless it is needed to
disambiguate from a locally scoped variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
