kamalcph commented on PR #15825:
URL: https://github.com/apache/kafka/pull/15825#issuecomment-2103912972

   While going through the usages, it looks to me that the LogOffsetMetadata 
conversion happens in the KafkaMetadataLog is not correct. Could someone please 
double check?
   
   ```
   org.apache.kafka.storage.internals.log.LogOffsetMetadata -> 
org.apache.kafka.raft.LogOffsetMetadata
   ```
   
   
https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/raft/KafkaMetadataLog.scala#L226
   
   Question: Why do we make the  
org.apache.kafka.raft.LogOffsetMetadata#segmentPosition as empty when 
hwm.messageOffsetOnly is false?
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to