vamossagar12 commented on code in PR #15305:
URL: https://github.com/apache/kafka/pull/15305#discussion_r1596476664
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinator.java:
##########
@@ -267,6 +267,18 @@ public String memberId() {
return JoinGroupRequest.UNKNOWN_MEMBER_ID;
}
+ @Override
+ protected void handlePollTimeoutExpiry() {
Review Comment:
Thanks Greg, I think that makes sense. I have extended the
`WorkerRebalanceListener` to add another hook upon poll timeout expiry which
the coordinator invokes. This way, it is able to access the tick thread's stage
which was being executed at that point of time. I am just thinking, could there
be race conditions where what we get in the tick thread stage might not always
reflect the point where tick thread is blocked (like it moved on by the time we
invoke this or becomes null), but I guess it should be ok because this can be
treated as best effort? WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
