gaurav-narula commented on PR #15885: URL: https://github.com/apache/kafka/pull/15885#issuecomment-2106081608
Thanks for the feedback @kamalcph @satishd! I've modified the tests so that we propagate a `Consumer<RemoteLogMetadata>` down to `ConsumerTask` and use it only for tests. This allows us to replace `waitUntilConsumerCatchesUp` with `TestUtils.waitForCondition` to actually wait on the consumption of all expected `RemoteLogMetadata` objects we set up in the tests instead of relying on offsets which is ambiguous. Please have a look and let me know your thoughts! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
