cadonna commented on code in PR #15942:
URL: https://github.com/apache/kafka/pull/15942#discussion_r1599755400
##########
streams/src/test/java/org/apache/kafka/streams/TopologyTest.java:
##########
@@ -330,8 +327,6 @@ public void shouldNotAllowToAddStateStoreToSink() {
private void mockStoreBuilder() {
when(storeBuilder.name()).thenReturn("store");
- when(storeBuilder.logConfig()).thenReturn(Collections.emptyMap());
Review Comment:
Yeah, it is somehow strange. We tried to define Mockito with strict stubs
but now with the migration to JUnit 5 it turns out that it was that strict
after all. I haven't yet understood why we get unnecessary stubbing exceptions.
🤔
In this specific case, it does not make any difference from a stubbing point
of view since the return values are the default return values. So instead of
considering `lenient`, I just removed the stubs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
