chia7712 commented on code in PR #15935:
URL: https://github.com/apache/kafka/pull/15935#discussion_r1600107425
##########
clients/src/main/java/org/apache/kafka/common/protocol/Readable.java:
##########
@@ -53,7 +54,7 @@ default List<RawTaggedField>
readUnknownTaggedField(List<RawTaggedField> unknown
return unknowns;
}
- default MemoryRecords readRecords(int length) {
+ default BaseRecords readRecords(int length) {
Review Comment:
> Hard-coded duplicating of MemoryRecords is not elegant. So I add a
duplicate method to BaseRecords. How do you think?
Could you file a KIP to let us know the whole picture? `MemoryRecords` is
used in code base, so we need to be careful of changing that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
