chickenchickenlove commented on code in PR #15926: URL: https://github.com/apache/kafka/pull/15926#discussion_r1600777761
########## metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java: ########## @@ -165,6 +165,8 @@ static ControllerResult<Void> recordsForNonEmptyLog( throw new RuntimeException("Should not have ZK migrations enabled on a cluster that was " + "created in KRaft mode."); } + logMessageBuilder + .append("since this is a de-novo KRaft cluster."); Review Comment: This is better 👍 I make a new commit to apply your comments. Please take another look, when you have free time 🙇♂️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org