prestona commented on code in PR #15910:
URL: https://github.com/apache/kafka/pull/15910#discussion_r1602207815
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java:
##########
@@ -105,7 +106,13 @@ private KafkaBasedLog<byte[], byte[]>
createBackingStore(MirrorCheckpointConfig
/**
* Start the OffsetSyncStore, blocking until all previous Offset Syncs
have been read from backing storage.
*/
- public void start() {
+ public void start(boolean initializationMustReadToEnd) {
+ this.initializationMustReadToEnd = initializationMustReadToEnd;
+ if (initializationMustReadToEnd) {
+ log.warn("OffsetSyncStore initializationMustReadToEnd = {}",
initializationMustReadToEnd);
Review Comment:
Our intention was to alert the Kafka admin that they are getting degraded
behavior. However, reflecting on this, I wonder if would be better to special
case "not authorized" such that:
1. For not authorized we emit a warning (with a better worded explanation) -
because the Kafka admin can choose to take an action that improves the
frequency of checkpoints.
1. For other cases, log at debug level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
