m1a2st commented on code in PR #15958: URL: https://github.com/apache/kafka/pull/15958#discussion_r1602821237
########## build.gradle: ########## @@ -671,7 +671,8 @@ subprojects { "-Xlint:private-shadow", "-Xlint:stars-align", "-Xlint:type-parameter-shadow", - "-Xlint:unused" + "-Xlint:unused", Review Comment: I catch two main errors are class is depreate (1. ) and `@nowarn` build error in previous build in Jenkins, but these classes or method are used by other classes. I consider that I should not migrate these methods or classes in this PR, thus I think I should closed these check when building scala version 2.3. 1. ([Error] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-15958/core/src/main/scala/kafka/controller/KafkaController.scala:1202:18: method setOrCreatePartitionReassignment in class KafkaZkClient is deprecated) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org