cadonna commented on code in PR #15978:
URL: https://github.com/apache/kafka/pull/15978#discussion_r1603562973


##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java:
##########
@@ -1377,47 +1377,6 @@ public void 
shouldOnlyCompleteShutdownAfterRebalanceNotInProgress() throws Inter
         assertEquals(Collections.emptySet(), 
thread.taskManager().activeTaskIds());
     }
 
-    @Test
-    public void shouldCloseAllTaskProducersOnCloseIfEosEnabled() throws 
InterruptedException {
-        internalTopologyBuilder.addSource(null, "source1", null, null, null, 
topic1);
-
-        thread = createStreamThread(
-            CLIENT_ID,
-            new StreamsConfig(configProps(true)),
-            new MockTime(1)
-        );
-
-        thread.start();

Review Comment:
   This combined with the calls on the thread below are the cause of the 
flakiness.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to