dongnuo123 commented on code in PR #15954:
URL: https://github.com/apache/kafka/pull/15954#discussion_r1603582917
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1244,15 +1244,16 @@ private void throwIfClassicProtocolUnmatched(
String requestProtocolType,
String requestProtocolName
) {
+ String protocolName =
member.supportedClassicProtocols().get().iterator().next().name();
Review Comment:
Yes, if `requestProtocolType` or `requestProtocolName` is null, the
validation will fail.
> we should only validate them if they are non-null.
We do validate them even if they are null in the existing classic group sync
to the classic group
https://github.com/apache/kafka/blob/056d232f4e28bf8e67e00f8ed2c103fdb0f3b78e/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java#L4335-L4342
so I think we should also fail the validation if either of them is null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
