ableegoldman commented on code in PR #15972:
URL: https://github.com/apache/kafka/pull/15972#discussion_r1607404895
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##########
@@ -1974,6 +1974,15 @@ public Set<InternalTopicConfig>
nonSourceChangelogTopics() {
return topicConfigs;
}
+ /**
+ *
+ * @return the set of changelog topics, which includes both source
changelog topics and non
+ * source changelog topics.
+ */
+ public Set<String> changelogTopics() {
+ return Collections.unmodifiableSet(new
HashSet<>(stateChangelogTopics.keySet()));
Review Comment:
I think you can skip the new HashSet step, that's pretty much redundant with
the unmodifiableSet and since we don't plan on modifying the returned set, it's
better to just wrap the keySet directly to save a bunch of unnecessary copying
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
