chia7712 commented on code in PR #16023: URL: https://github.com/apache/kafka/pull/16023#discussion_r1608736058
########## core/src/main/scala/kafka/log/LogCleaner.scala: ########## @@ -109,12 +110,12 @@ class LogCleaner(initialConfig: CleanerConfig, private[log] val cleanerManager = new LogCleanerManager(logDirs, logs, logDirFailureChannel) /* a throttle used to limit the I/O of all the cleaner threads to a user-specified maximum rate */ - private[log] val throttler = new Throttler(desiredRatePerSec = config.maxIoBytesPerSecond, - checkIntervalMs = 300, - throttleDown = true, - "cleaner-io", - "bytes", - time = time) + private[log] val throttler = new Throttler(config.maxIoBytesPerSecond, + 300, + true, Review Comment: It seems `throttleDown` is always true in production. Maybe we can remove it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
