kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1608934073


##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##########
@@ -281,64 +276,15 @@ void testEnsureMetadataUpdateOnPoll() {
     }
 
     @Test
-    void testEnsureEventsAreCompleted() {

Review Comment:
   Yes, the test was a little suspect in terms of its value-add, so I'd removed 
it.
   
   I was planning to file a Jira to move several of the tests (including this 
one) from `ConsumerNetworkThreadTest` to `ApplicationEventProcessorTest`. Then 
we could fix up some of the funkiness in this test as a separate task.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to